[cfe-commits] [PATCH] Initial version of formatting library

Sean Silva silvas at purdue.edu
Wed Nov 14 12:18:15 PST 2012



================
Comment at: include/clang/Format/Format.h:10-13
@@ +9,6 @@
+//
+//  This is EXPERIMENTAL code under heavy development. It is not in a state yet,
+//  where it can be used to format real code.
+//
+//  Various functions to configurably format source code.
+//
----------------
Just an idea, but maybe you could "grow" this inside clang-tools-extra as part of a dedicated tool, and then promote it to the main repo as it matures? clang-format, is, first and foremost, a tool (as it says in Manuel's design document), and not really a "library". It should be developed as a tool IMO.

As the tool materializes, reusable parts will probably be easy to identify and at that point it will be clear what kind of API "surface area" is correct to expose; Manuel's design document seems to specifically leave this as something to be done later as more experience is gained.

As it stands right now in the current patch, it looks like this is going down a path to the "main() in a library" antipattern like TableGen currently is.


http://llvm-reviews.chandlerc.com/D80



More information about the cfe-commits mailing list