[cfe-commits] [patch] Add a llvm::Triple::CPUArch enum

[Daniel Dunbar]

Yes, but still seems to add API and code around something that isn't worth
promoting:
--
diffstat t.patch
 ToolChains.cpp |  100
+++++++++++++++++++++++++++++++++++----------------------
 Tools.cpp      |   97
+++++++++++++++++++++++++++++++++++++++++++++----------
 Tools.h        |   34 +++++++++++++++++++
 3 files changed, 177 insertions(+), 54 deletions(-)
--

 - Daniel



On Wed, Oct 31, 2012 at 3:51 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 31 October 2012 13:55, Daniel Dunbar <daniel at zuster.org> wrote:
> > I think very little of the char* handling in the driver is related to
> this
> > particular issue.
> >
> > I'm hesitant to promote the very specialized Darwin CPU arch naming
> scheme
> > higher in the API. This isn't really a useful scheme (i.e., no one else
> > should use this notion), but is required for Darwin compatibility.
> >
> > If anything, I'd rather go the other direction and localize
> > getArchTypeForDarwinArchName into Clang.
>
> Those are fairly independent changes. I have moved
> getArchTypeForDarwinArchName to lib/Driver. The attached patch is
> rebased on top of that. Note that only this patch already removes a
> "switch" over strings (converts one StringSwitch and a if chain into
> one StringSwitch.).
>
> >  - Daniel
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121031/40c909cb/attachment.html>