[cfe-commits] [patch] Add a llvm::Triple::CPUArch enum

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Oct 31 15:51:38 PDT 2012


On 31 October 2012 13:55, Daniel Dunbar <daniel at zuster.org> wrote:
> I think very little of the char* handling in the driver is related to this
> particular issue.
>
> I'm hesitant to promote the very specialized Darwin CPU arch naming scheme
> higher in the API. This isn't really a useful scheme (i.e., no one else
> should use this notion), but is required for Darwin compatibility.
>
> If anything, I'd rather go the other direction and localize
> getArchTypeForDarwinArchName into Clang.

Those are fairly independent changes. I have moved
getArchTypeForDarwinArchName to lib/Driver. The attached patch is
rebased on top of that. Note that only this patch already removes a
"switch" over strings (converts one StringSwitch and a if chain into
one StringSwitch.).

>  - Daniel

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 9574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121031/188eeef6/attachment.obj>


More information about the cfe-commits mailing list