[cfe-commits] r164874 - in /cfe/trunk: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/Frontend/DependencyFile.cpp lib/Frontend/DependencyGraph.cpp lib/Lex/PPDirectives.cpp lib/Lex/PreprocessingRecord.cpp lib/Lex/Prepr

[Kim Gräsman]

On Sat, Sep 29, 2012 at 11:50 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
>
> I would expect either '<stdio.h>' or
> 'HEADER_NAME', but I think getting the expanded range ('<stdio.h>')
> would be the most natural.

Having looked into our callback implementation, we already handle
macro expansion, and I think passing down the macro name range
unexpanded gives more fidelity. So I change my mind -- I think getting
the range as-written would be better ('HEADER_NAME'). Of course,
assuming that FilenameRange.getBegin().isMacroID() is still true so
callback sinks can expand it.

Thanks,
- Kim