[cfe-commits] r164874 - in /cfe/trunk: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/Frontend/DependencyFile.cpp lib/Frontend/DependencyGraph.cpp lib/Lex/PPDirectives.cpp lib/Lex/PreprocessingRecord.cpp lib/Lex/Prepr

[Kim Gräsman]

Hi Argyrios,

This really concerns your previous commit changing PPCallbacks, but I
wasn't subscribed to cfe-commits when that happened, so I'll respond
here.

I like the new CharSourceRange argument to
PPCallbacks::InclusionDirective, but I'm not sure what it should
return for a computed include, e.g.:

#define HEADER_NAME <stdio.h>
#include HEADER_NAME

Currently this returns the following range;

'<stdio.h>
#include HEADER_NAME'

which seems a little off. I would expect either '<stdio.h>' or
'HEADER_NAME', but I think getting the expanded range ('<stdio.h>')
would be the most natural.

Thoughts?

Thanks,
- Kim

On Sat, Sep 29, 2012 at 3:06 AM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:
> Author: akirtzidis
> Date: Fri Sep 28 20:06:10 2012
> New Revision: 164874
>
> URL: http://llvm.org/viewvc/llvm-project?rev=164874&view=rev
> Log:
> For PPCallbacks::InclusionDirective() add a parameter for the module, whenever
> an inclusion directive was automatically turned into a module import, and
> PPCallbacks::moduleImport() for an explicit module import.