[cfe-commits] [PATCH] Update Hexagon ToolChain (call linker directly, addl args, , etc)

[Chandler Carruth]

On Wed, Sep 12, 2012 at 1:01 PM, Matthew Curtis <mcurtis at codeaurora.org>wrote:

>  Any objections to submitting this patch?
>

It hasn't been review yet...

Anyways, I'll take this as a ping.


>
> Matthew Curtis.
>
>
> On 9/6/2012 4:24 PM, Matthew Curtis wrote:
>
> Hello all,
>
> This patch updates the Hexagon ToolChain:
>
> Rather than one patch that is a grab-bag of updates, how about posting
patches incrementally addressing the issues?

You seem to already have them broken apart here:


> - reimplement hexagon::Link::ConstructJob to call linker directly
>   rather than going through gcc
> - add/improve support for small data threshold, pic, and other args
> - add overrides for include paths, et. al.
> - minor refactoring
>
> If possible, can you post the minor refactoring (no functionality changes)
patch first? It will likely make the others easier to review.


Also, there are no test updates or new test cases despite a very
significant set of changes. Each patch needs to either be a simple
refactoring (no functionality changes), or to have an update to a test
case, or to have a new test case to cover the new behavior.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120912/7703b5ad/attachment.html>