[cfe-commits] r163202 - /cfe/trunk/lib/CodeGen/CGExprConstant.cpp

Richard Smith richard at metafoo.co.uk
Mon Sep 10 22:53:11 PDT 2012


On Mon, Sep 10, 2012 at 9:54 PM, Douglas Gregor <dgregor at apple.com> wrote:

>
> On Sep 5, 2012, at 1:37 AM, Jin-Gu Kang <jaykang10 at imrc.kist.re.kr> wrote:
>
> > Author: jaykang10
> > Date: Wed Sep  5 03:37:43 2012
> > New Revision: 163202
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=163202&view=rev
> > Log:
> > Changing of type checking order on InitListExpr
> > - UnionType is checked eariler than RecordType.
>
> Do you have a test case for this change?
>

EmitStructInitialization and EmitUnionInitialization are identical. Tidied
up in r163595.

        - Doug
>
> > Modified:
> >    cfe/trunk/lib/CodeGen/CGExprConstant.cpp
> >
> > Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprConstant.cpp?rev=163202&r1=163201&r2=163202&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/lib/CodeGen/CGExprConstant.cpp (original)
> > +++ cfe/trunk/lib/CodeGen/CGExprConstant.cpp Wed Sep  5 03:37:43 2012
> > @@ -830,12 +830,12 @@
> >     if (ILE->getType()->isArrayType())
> >       return EmitArrayInitialization(ILE);
> >
> > -    if (ILE->getType()->isRecordType())
> > -      return EmitStructInitialization(ILE);
> > -
> >     if (ILE->getType()->isUnionType())
> >       return EmitUnionInitialization(ILE);
> >
> > +    if (ILE->getType()->isRecordType())
> > +      return EmitStructInitialization(ILE);
> > +
> >     return 0;
> >   }
> >
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120910/a8470279/attachment.html>


More information about the cfe-commits mailing list