<div class="gmail_quote">On Mon, Sep 10, 2012 at 9:54 PM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
On Sep 5, 2012, at 1:37 AM, Jin-Gu Kang <<a href="mailto:jaykang10@imrc.kist.re.kr">jaykang10@imrc.kist.re.kr</a>> wrote:<br>
<br>
> Author: jaykang10<br>
> Date: Wed Sep  5 03:37:43 2012<br>
> New Revision: 163202<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163202&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=163202&view=rev</a><br>
> Log:<br>
> Changing of type checking order on InitListExpr<br>
> - UnionType is checked eariler than RecordType.<br>
<br>
</div>Do you have a test case for this change?<br></blockquote><div><br></div>EmitStructInitialization and EmitUnionInitialization are identical. Tidied up in r163595.<br><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
        - Doug<br>
<div class="HOEnZb"><div class="h5"><br>
> Modified:<br>
>    cfe/trunk/lib/CodeGen/CGExprConstant.cpp<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprConstant.cpp?rev=163202&r1=163201&r2=163202&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprConstant.cpp?rev=163202&r1=163201&r2=163202&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CGExprConstant.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/CGExprConstant.cpp Wed Sep  5 03:37:43 2012<br>
> @@ -830,12 +830,12 @@<br>
>     if (ILE->getType()->isArrayType())<br>
>       return EmitArrayInitialization(ILE);<br>
><br>
> -    if (ILE->getType()->isRecordType())<br>
> -      return EmitStructInitialization(ILE);<br>
> -<br>
>     if (ILE->getType()->isUnionType())<br>
>       return EmitUnionInitialization(ILE);<br>
><br>
> +    if (ILE->getType()->isRecordType())<br>
> +      return EmitStructInitialization(ILE);<br>
> +<br>
>     return 0;<br>
>   }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br>