[cfe-commits] [PATCH] New clang-check vim integration script

[Alexander Kornienko]

On Tue, Sep 4, 2012 at 5:01 PM, Alexander Kornienko <alexfh at google.com>wrote:

> On Tue, Sep 4, 2012 at 4:38 PM, Nico Weber <thakis at chromium.org> wrote:
>
>> ...
>> Remove.
>>
>>
>>>  +  let l:output = system(a:cmd)
>>> +  cexpr l:output
>>> +  cwindow
>>>
>> +  let w:quickfix_title = a:cmd
>>> +  if v:shell_error != 0
>>> +    cc
>>> +  endif
>>>
>>
>> Replace all that with
>>
>>   let l:oldmakepgr = &makeprg
>>   let &makeprg = a:cmd
>>   silent make | cwindow
>>   let &makeprg = l:oldmakepgr
>>
>> (Gives you a warning when trying to compile a modified buffer too)
>>
> Doesn't work for me: after running your code vim (7.3, if this matters)
> doesn't repaint it's window, and I end up having a blank screen until I
> make vim repaint everything.

The problem is with "silent". But when I remove it, I have to hit Enter
after running this function, and, what is more important, it doesn't
display a warning when trying to compile a modified buffer. So, at least on
my configuration of vim 7.3 this change doesn't make sense.

-- 
Regards,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120904/473ae0d6/attachment.html>