[cfe-commits] [PATCH] Rename matchers to better match AST nodes

Daniel Jasper djasper at google.com
Sun Aug 26 17:57:51 PDT 2012


You either have not read/understood my last comment/commit message or I
don't understand what you mean.

Cheers,
Daniel


On Sun, Aug 26, 2012 at 6:58 AM, Sean Silva <
reviews at llvm-reviews.chandlerc.com> wrote:

>
>   If it's not completely consistent, then you lose the ability to say,
>   in one sentence "the correspondence is X", which still means you have
>   to go back to the docs to look up the correspondence ("is this one of
>   the ones that isn't named consistently?").
>
>   I think that it is a case of "premature optimization" to not go all
>   the way. Why not "go all the way" and then scale back later if it gets
>   to be a pain to write or another issue is found?
>
>   Thanks,
>
>   --Sean Silva
>
> http://llvm-reviews.chandlerc.com/D21
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120826/e3fdc243/attachment.html>


More information about the cfe-commits mailing list