[cfe-commits] [PATCH] Find comment attached to any redeclaration

Dmitri Gribenko gribozavr at gmail.com
Fri Aug 10 17:53:22 PDT 2012


On Fri, Aug 10, 2012 at 4:45 PM, Douglas Gregor <dgregor at apple.com> wrote:
> On Aug 8, 2012, at 11:38 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> On Tue, Aug 7, 2012 at 4:43 PM, Douglas Gregor <dgregor at apple.com> wrote:
>>> This uncached search seems a bit pessimistic. Why not peek into the cache for each of the redeclarations, to avoid repeatedly performing the unchanged search. Then, when we actually do find a raw comment attached to one of the declarations, update the cache for each of the redeclarations to point at that same raw comment?
>>
>> I've implemented your suggestion.  Unfortunately, this required some
>> code restructuring in order not to re-parse one RawComment when it is
>> attached to multiple redeclarations.
>
> This looks great, thanks!

Thank you for reviewing, committed r161722.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/




More information about the cfe-commits mailing list