[cfe-commits] [PATCH] Find comment attached to any redeclaration

Douglas Gregor dgregor at apple.com
Fri Aug 10 16:45:08 PDT 2012


On Aug 8, 2012, at 11:38 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Tue, Aug 7, 2012 at 4:43 PM, Douglas Gregor <dgregor at apple.com> wrote:
>> 
>> This uncached search seems a bit pessimistic. Why not peek into the cache for each of the redeclarations, to avoid repeatedly performing the unchanged search. Then, when we actually do find a raw comment attached to one of the declarations, update the cache for each of the redeclarations to point at that same raw comment?
> 
> I've implemented your suggestion.  Unfortunately, this required some
> code restructuring in order not to re-parse one RawComment when it is
> attached to multiple redeclarations.

This looks great, thanks!

	- Doug



More information about the cfe-commits mailing list