[cfe-commits] [OpenCL patch] Optional attributes (non-controversial)

[Chad Rosier]

I just threw it under the IgnoredAttr group in 159966, but this isn't likely the right grouping.

Oh.. I see you just modified the test case.  I'll just revert my patch then.

 Chad


On Jul 9, 2012, at 3:57 PM, Tanya Lattner wrote:

> Ok. Should this be under its own flag or a group flag? I notice a lot of the attribute warnings are not under a flag. 
> 
> Thanks,
> Tanya
> 
> On Jul 9, 2012, at 3:37 PM, Chad Rosier wrote:
> 
>> This commit is causing buildbot failures:
>> ******************** TEST 'Clang :: Misc/warning-flags.c' FAILED ********************Script:
>> --
>> diagtool list-warnings | FileCheck test/Misc/warning-flags.c
>> --
>> Exit Code: 1
>> Command Output (stderr):
>> --
>> test/Misc/warning-flags.c:20:8: error: expected string not found in input
>> CHECK: Warnings without flags (158):
>>        ^
>> <stdin>:1:1: note: scanning from here
>> Warnings with flags (680):
>> ^
>> --
>> I believe the new warning just needs to be put under a flag.
>> 
>>  Chad
>> 
>> 
>> On Jul 9, 2012, at 3:06 PM, Tanya Lattner wrote:
>> 
>>> Committed in r159965.
>>> 
>>> Thank you!
>>> -Tanya
>>> 
>>> On Jul 7, 2012, at 12:21 AM, Anton Lokhmotov wrote:
>>> 
>>>> Thanks Tanya.  Yes, please.
>>>> 
>>>> Best regards,
>>>> Anton.
>>>> 
>>>> ________________________________________
>>>> From: Tanya Lattner [lattner at apple.com]
>>>> Sent: 07 July 2012 01:34
>>>> To: Anton Lokhmotov
>>>> Cc: cfe-commits at cs.uiuc.edu; 'Benyei, Guy'
>>>> Subject: Re: [OpenCL patch] Optional attributes (non-controversial)
>>>> 
>>>> This looks good to me. Do you need me to commit it?
>>>> 
>>>> -Tanya
>>>> 
>>>> On Jun 28, 2012, at 7:41 AM, Anton Lokhmotov wrote:
>>>> 
>>>>> Hi Tanya,
>>>>> 
>>>>> I've followed your advice and separated code for the work group size
>>>>> attributes (attached) and the other attributes (to be submitted shortly).
>>>>> Please review.
>>>>> 
>>>>> Best wishes,
>>>>> Anton.
>>>>> 
>>>>> 
>>>>>> -----Original Message-----
>>>>>> From: Tanya Lattner [mailto:lattner at apple.com]
>>>>>> Sent: 23 June 2012 00:35
>>>>>> To: Anton Lokhmotov
>>>>>> Cc: cfe-commits at cs.uiuc.edu; 'Benyei, Guy'
>>>>>> Subject: Re: [OpenCL patch] Optional attributes
>>>>>> 
>>>>>> Anton,
>>>>>> 
>>>>>> I think it may be beneficial to separate out the DummyTypeExpr part
>>>>>> from this patch and have it reviewed separately. Its the only really
>>>>>> concerning part from this patch if I remember right.
>>>>>> 
>>>>>> -Tanya
>>>>>> 
>>>>>> On Jun 14, 2012, at 4:06 PM, Anton Lokhmotov <Anton.Lokhmotov at arm.com>
>>>>>> wrote:
>>>>>> 
>>>>>>> I would like to return to optional attributes [1].  Here's an update
>>>>>> with
>>>>>>> better error handling and tests.  Can be a good starting point to
>>>>>> resume
>>>>>>> resolving [2].  Please review.
>>>>>>> 
>>>>>>> Many thanks,
>>>>>>> Anton.
>>>>>>> 
>>>>>>> [1] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-
>>>>>> January/019448.html
>>>>>>> [2] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-
>>>>>> January/019611.html<attributes.patch>
>>>>> <attributes0.patch>
>>>> 
>>>> 
>>>> 
>>>> 
>>>> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
>>>> 
>>> 
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120709/79cc9e8d/attachment.html>