<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I just threw it under the IgnoredAttr group in 159966, but this isn't likely the right grouping.<div><br></div><div><div>Oh.. I see you just modified the test case.  I'll just revert my patch then.</div><div><br></div><div> Chad</div><div><br></div><div><br><div><div>On Jul 9, 2012, at 3:57 PM, Tanya Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Ok. Should this be under its own flag or a group flag? I notice a lot of the attribute warnings are not under a flag. <div><br></div><div>Thanks,</div><div>Tanya</div><div><br><div><div>On Jul 9, 2012, at 3:37 PM, Chad Rosier wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">This commit is causing buildbot failures:<div><span class="Apple-style-span" style="font-family: Times; "><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout" style="font-family: 'Courier New', courier, monotype; color: black; ">******************** TEST 'Clang :: Misc/warning-flags.c' FAILED ********************Script:
--
diagtool list-warnings | FileCheck test/Misc/warning-flags.c
--
Exit Code: 1
Command Output (stderr):
--
test/Misc/warning-flags.c:20:8: error: expected string not found in input
CHECK: Warnings without flags (158):
       ^
<stdin>:1:1: note: scanning from here
Warnings with flags (680):
^
--</span></pre></span><div>I believe the new warning just needs to be put under a flag.</div><div><br></div><div> Chad</div><div><br></div><div><br><div><div>On Jul 9, 2012, at 3:06 PM, Tanya Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Committed in r159965.<br><br>Thank you!<br>-Tanya<br><br>On Jul 7, 2012, at 12:21 AM, Anton Lokhmotov wrote:<br><br><blockquote type="cite">Thanks Tanya.  Yes, please.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Best regards,<br></blockquote><blockquote type="cite">Anton.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">________________________________________<br></blockquote><blockquote type="cite">From: Tanya Lattner [<a href="mailto:lattner@apple.com">lattner@apple.com</a>]<br></blockquote><blockquote type="cite">Sent: 07 July 2012 01:34<br></blockquote><blockquote type="cite">To: Anton Lokhmotov<br></blockquote><blockquote type="cite">Cc: <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>; 'Benyei, Guy'<br></blockquote><blockquote type="cite">Subject: Re: [OpenCL patch] Optional attributes (non-controversial)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">This looks good to me. Do you need me to commit it?<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">-Tanya<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On Jun 28, 2012, at 7:41 AM, Anton Lokhmotov wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">Hi Tanya,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">I've followed your advice and separated code for the work group size<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">attributes (attached) and the other attributes (to be submitted shortly).<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Please review.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Best wishes,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Anton.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">-----Original Message-----<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">From: Tanya Lattner [mailto:lattner@apple.com]<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Sent: 23 June 2012 00:35<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">To: Anton Lokhmotov<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Cc: <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>; 'Benyei, Guy'<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Subject: Re: [OpenCL patch] Optional attributes<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Anton,<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">I think it may be beneficial to separate out the DummyTypeExpr part<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">from this patch and have it reviewed separately. Its the only really<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">concerning part from this patch if I remember right.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">-Tanya<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">On Jun 14, 2012, at 4:06 PM, Anton Lokhmotov <<a href="mailto:Anton.Lokhmotov@arm.com">Anton.Lokhmotov@arm.com</a>><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">wrote:<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">I would like to return to optional attributes [1].  Here's an update<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">with<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">better error handling and tests.  Can be a good starting point to<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">resume<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">resolving [2].  Please review.<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Many thanks,<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Anton.<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">[1] <a href="http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-">http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-</a><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">January/019448.html<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">[2] <a href="http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-">http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-</a><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">January/019611.html<attributes.patch><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><attributes0.patch><br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.<br></blockquote><blockquote type="cite"><br></blockquote><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div></blockquote></div><br></div></div></body></html>