[cfe-commits] PATCH: Make OBJC_AT_KEYWORD_NAME more Doxygen- (and human-) friendly.

Chandler Carruth chandlerc at google.com
Wed Jun 13 20:08:57 PDT 2012


On Wed, Jun 13, 2012 at 7:58 PM, James Dennett <jdennett at google.com> wrote:

> This makes SemaCodeComplete.cpp more Doxygen-friendly by changing the
> OBJC_AT_KEYWORD_NAME take a string literal argument where previously
> its second argument was an unquoted token; macro invocations such as
> OBJC_AT_KEYWORD_NAME(NeedAt,{) confuse Doxygen's parser.
>
> While I'm wary of changing code (rather than just comments) to work
> around Doxygen's limitations, in this case the change makes the code
> more readable for human beings as well, and the macro derived no
> benefit from using the preprocessor's stringification operator, as
> it never has need of the unquoted token.
>
> I've also included a couple of trivial drive-by fixes to doc comments.


LGTM. There is no functionality changed, so feel free to submit and folks
can chime in on the commit if there are any concerns.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120613/c802a270/attachment.html>


More information about the cfe-commits mailing list