[cfe-commits] r158229 - /cfe/trunk/lib/Frontend/TextDiagnostic.cpp

[Chandler Carruth]

On Fri, Jun 8, 2012 at 2:41 PM, Matt Beaumont-Gay <matthewbg at google.com>wrote:

> +clattner
>
> On Fri, Jun 8, 2012 at 2:37 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> >
> > On Jun 8, 2012, at 14:29 , Matt Beaumont-Gay <matthewbg at google.com>
> wrote:
> >
> >> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-August/016685.html
> >> http://llvm.org/bugs/show_bug.cgi?id=10696
> >>
> >> (h/t dblaikie)
> >>
> >> -Matt
> >
> > Oops. There Chris said we should just drop the fixit, rather than slide
> over the second hint. Which solution do you think is better?
>
> Well, he actually said "we should just drop the fixit if we can't
> format it in a useful way." I think your solution is pretty useful,
> myself, but Chris probably has an opinion :)


I think the "if we can't" is clear. ;] Comment on the bug accordingly.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120608/4146f5a5/attachment.html>