[cfe-commits] r158229 - /cfe/trunk/lib/Frontend/TextDiagnostic.cpp

[Matt Beaumont-Gay]

+clattner

On Fri, Jun 8, 2012 at 2:37 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>
> On Jun 8, 2012, at 14:29 , Matt Beaumont-Gay <matthewbg at google.com> wrote:
>
>> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-August/016685.html
>> http://llvm.org/bugs/show_bug.cgi?id=10696
>>
>> (h/t dblaikie)
>>
>> -Matt
>
> Oops. There Chris said we should just drop the fixit, rather than slide over the second hint. Which solution do you think is better?

Well, he actually said "we should just drop the fixit if we can't
format it in a useful way." I think your solution is pretty useful,
myself, but Chris probably has an opinion :)

>
> (I don't really think something like this deserves a flag; we should just pick one way and stick with it.)

+1

-Matt