[cfe-commits] r156493 - /cfe/trunk/test/Driver/target-triple-deployment.c

[Chad Rosier]

On May 9, 2012, at 11:30 AM, Chandler Carruth wrote:

> On Wed, May 9, 2012 at 11:29 AM, Chandler Carruth <chandlerc at google.com> wrote:
> 
> 
> 2012/5/9 Chad Rosier <mcrosier at apple.com>
> Author: mcrosier
> Date: Wed May  9 13:23:04 2012
> New Revision: 156493
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=156493&view=rev
> Log:
> Update test case for new default of 3.0
> 
> Modified:
>    cfe/trunk/test/Driver/target-triple-deployment.c
> 
> Maybe we shouldn't check the version numbers here in specificity, and rely on the llvm::Triple tests?
> 
> To be more clear -- should we not check *which* default version we get, and just check that we did get a (non-zero) default version? I understand we want to make sure that the llvm::Triple is in fact being used here.

Hi Chandler,
I've added the Triple unittests in llvm revision 156507.  Are you opposed to leaving this test case in place to ensure the driver is working as expected?

 Chad

>  
> 
> Modified: cfe/trunk/test/Driver/target-triple-deployment.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-triple-deployment.c?rev=156493&r1=156492&r2=156493&view=diff
> ==============================================================================
> --- cfe/trunk/test/Driver/target-triple-deployment.c (original)
> +++ cfe/trunk/test/Driver/target-triple-deployment.c Wed May  9 13:23:04 2012
> @@ -21,10 +21,10 @@
>  // CHECK: 10.7.0
>  // CHECK: {{ld(.exe)?"}}
>  // CHECK: -iphoneos_version_min
> -// CHECK: 0.0.0
> +// CHECK: 3.0.0
>  // CHECK: {{ld(.exe)?"}}
>  // CHECK: -iphoneos_version_min
> -// CHECK: 0.0.0
> +// CHECK: 3.0.0
>  // CHECK: {{ld(.exe)?"}}
>  // CHECK: -iphoneos_version_min
>  // CHECK: 1.2.3
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120509/8073fcf2/attachment.html>