<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 9, 2012, at 11:30 AM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Wed, May 9, 2012 at 11:29 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote"><div class="im">2012/5/9 Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: mcrosier<br>
Date: Wed May 9 13:23:04 2012<br>
New Revision: 156493<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=156493&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=156493&view=rev</a><br>
Log:<br>
Update test case for new default of 3.0<br>
<br>
Modified:<br>
cfe/trunk/test/Driver/target-triple-deployment.c<br></blockquote><div><br></div></div><div>Maybe we shouldn't check the version numbers here in specificity, and rely on the llvm::Triple tests?</div></div></blockquote>
<div><br></div><div>To be more clear -- should we not check *which* default version we get, and just check that we did get a (non-zero) default version? I understand we want to make sure that the llvm::Triple is in fact being used here.</div></div></blockquote><div><br></div><div>Hi Chandler,</div><div>I've added the Triple unittests in llvm revision 156507. Are you opposed to leaving this test case in place to ensure the driver is working as expected?</div><div><br></div><div> Chad</div><br><blockquote type="cite"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified: cfe/trunk/test/Driver/target-triple-deployment.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-triple-deployment.c?rev=156493&r1=156492&r2=156493&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-triple-deployment.c?rev=156493&r1=156492&r2=156493&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/target-triple-deployment.c (original)<br>
+++ cfe/trunk/test/Driver/target-triple-deployment.c Wed May 9 13:23:04 2012<br>
@@ -21,10 +21,10 @@<br>
// CHECK: 10.7.0<br>
// CHECK: {{ld(.exe)?"}}<br>
// CHECK: -iphoneos_version_min<br>
-// CHECK: 0.0.0<br>
+// CHECK: 3.0.0<br>
// CHECK: {{ld(.exe)?"}}<br>
// CHECK: -iphoneos_version_min<br>
-// CHECK: 0.0.0<br>
+// CHECK: 3.0.0<br>
// CHECK: {{ld(.exe)?"}}<br>
// CHECK: -iphoneos_version_min<br>
// CHECK: 1.2.3<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div><br>
</blockquote></div><br>
</blockquote></div><br></body></html>