[cfe-commits] [Patch] [PythonBindings] Exposing cursor semantic and lexical parent to python (now with proper tests)

[Evan Pipho]

Ping.  I think this one is ready to go in.
Thanks
-Evan

On Wed, May 2, 2012 at 2:48 PM, Evan Pipho <hiwrac at gmail.com> wrote:

> Resending since I seem to have busted my subscription to cfe-commits and I
> got a message bounce and it got sent just to Manuel.
>
>
>
> On Wed, May 2, 2012 at 2:44 PM, Evan Pipho <hiwrac at gmail.com> wrote:
>
>> Totally agreed.
>>
>> Last edit (I hope).
>>
>>
>> On Wed, May 2, 2012 at 2:02 PM, Manuel Klimek <klimek at google.com> wrote:
>>
>>> On Wed, May 2, 2012 at 10:54 PM, Evan Pipho <hiwrac at gmail.com> wrote:
>>> > I am assuming you meant my comments for get_cursors in the test utils.
>>>  If
>>> > so, fixed.
>>>
>>> Also, the brief comment at the top both in utils.py and cindex.py.
>>> Looking around the surrounding methods seem to have a '.' in the end,
>>> so I think new code should follow the example...
>>>
>>> Cheers,
>>> /Manuel
>>>
>>> >
>>> >
>>> > On Wed, May 2, 2012 at 10:23 AM, Manuel Klimek <klimek at google.com>
>>> wrote:
>>> >>
>>> >> Looks good.
>>> >>
>>> >> Very minor nit: Comments are easier to read (IMO) if you're adding a
>>> >> '.' when you have a full sentence.
>>> >>
>>> >> On Tue, May 1, 2012 at 7:37 AM, Evan P <hiwrac at gmail.com> wrote:
>>> >> > When I was writing tests for the original version of this patch I
>>> >> > discovered
>>> >> > that clang_getCursorLexicalParent was actually broken for some edge
>>> >> > cases.
>>> >> > Now that my patch for that issue was committed in r155858, lets try
>>> this
>>> >> > again.
>>> >> >
>>> >> > - Adding lexical_parent and semantic_parent properties to
>>> >> > clang.cindex.Cursor
>>> >> > - Two new tests (one for each property), require libclang built from
>>> >> > r155858
>>> >> > or later to pass
>>> >> > - New test utility function (get_cursors) that gets all the nodes
>>> with a
>>> >> > specific spelling.
>>> >> >
>>> >> >
>>> >> > Thanks
>>> >> > -Evan Pipho
>>> >> >
>>> >> >
>>> >> >
>>> >> > _______________________________________________
>>> >> > cfe-commits mailing list
>>> >> > cfe-commits at cs.uiuc.edu
>>> >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>> >> >
>>> >
>>> >
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120504/777f91f9/attachment.html>