Ping. I think this one is ready to go in.<div>Thanks</div><div>-Evan<br><br><div class="gmail_quote">On Wed, May 2, 2012 at 2:48 PM, Evan Pipho <span dir="ltr"><<a href="mailto:hiwrac@gmail.com" target="_blank">hiwrac@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Resending since I seem to have busted my subscription to cfe-commits and I got a message bounce and it got sent just to Manuel.<div class="HOEnZb">
<div class="h5"><div><br><div><div><br><br><div class="gmail_quote">On Wed, May 2, 2012 at 2:44 PM, Evan Pipho <span dir="ltr"><<a href="mailto:hiwrac@gmail.com" target="_blank">hiwrac@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Totally agreed.<div><br></div><div>Last edit (I hope).<div><div><br><br><div class="gmail_quote">On Wed, May 2, 2012 at 2:02 PM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Wed, May 2, 2012 at 10:54 PM, Evan Pipho <<a href="mailto:hiwrac@gmail.com" target="_blank">hiwrac@gmail.com</a>> wrote:<br>
> I am assuming you meant my comments for get_cursors in the test utils. If<br>
> so, fixed.<br>
<br>
</div>Also, the brief comment at the top both in utils.py and cindex.py.<br>
Looking around the surrounding methods seem to have a '.' in the end,<br>
so I think new code should follow the example...<br>
<br>
Cheers,<br>
/Manuel<br>
<div><div><br>
><br>
><br>
> On Wed, May 2, 2012 at 10:23 AM, Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>> wrote:<br>
>><br>
>> Looks good.<br>
>><br>
>> Very minor nit: Comments are easier to read (IMO) if you're adding a<br>
>> '.' when you have a full sentence.<br>
>><br>
>> On Tue, May 1, 2012 at 7:37 AM, Evan P <<a href="mailto:hiwrac@gmail.com" target="_blank">hiwrac@gmail.com</a>> wrote:<br>
>> > When I was writing tests for the original version of this patch I<br>
>> > discovered<br>
>> > that clang_getCursorLexicalParent was actually broken for some edge<br>
>> > cases.<br>
>> > Now that my patch for that issue was committed in r155858, lets try this<br>
>> > again.<br>
>> ><br>
>> > - Adding lexical_parent and semantic_parent properties to<br>
>> > clang.cindex.Cursor<br>
>> > - Two new tests (one for each property), require libclang built from<br>
>> > r155858<br>
>> > or later to pass<br>
>> > - New test utility function (get_cursors) that gets all the nodes with a<br>
>> > specific spelling.<br>
>> ><br>
>> ><br>
>> > Thanks<br>
>> > -Evan Pipho<br>
>> ><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > cfe-commits mailing list<br>
>> > <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
>> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
>> ><br>
><br>
><br>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br>
</div></div></div>
</div></div></blockquote></div><br></div>