[cfe-commits] [PATCH] "-gline-tables-only" flag for Clang

[Eric Christopher]

On Apr 28, 2012, at 4:07 PM, Eric Christopher wrote:

>> 
>> Sending the revised (modulo r155697) patch. Please take a look.
>> 
>> Codereview: http://codereview.appspot.com/6112056/#ps9001
> 
> I think about the only comment I've got is whether or not we should use comparison operators instead of == and != in these sorts of cases?
> 
> -    Dbg->EmitGlobalVariable(E->getDecl(), Init);
> +    if (CGM.getCodeGenOpts().DebugInfo != CodeGenOptions::DebugLineTablesOnly)
> +      Dbg->EmitGlobalVariable(E->getDecl(), Init);
> 
> I'd prefer it personally. Your thoughts?

Also for the asserts etc. It really should be > there for consistency :)

-eric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120428/f958d3d1/attachment.html>