<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 28, 2012, at 4:07 PM, Eric Christopher wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Sending the revised (modulo r155697) patch. Please take a look.</div><div><br></div><div>Codereview: <a href="http://codereview.appspot.com/6112056/#ps9001">http://codereview.appspot.com/6112056/#ps9001</a></div>
</div></div></blockquote><br></div><div>I think about the only comment I've got is whether or not we should use comparison operators instead of == and != in these sorts of cases?</div><div><br></div><div><div>- Dbg->EmitGlobalVariable(E->getDecl(), Init);</div><div>+ if (CGM.getCodeGenOpts().DebugInfo != CodeGenOptions::DebugLineTablesOnly)</div><div>+ Dbg->EmitGlobalVariable(E->getDecl(), Init);</div><div><br></div></div><div>I'd prefer it personally. Your thoughts?</div></div></blockquote><br></div><div>Also for the asserts etc. It really should be > there for consistency :)</div><div><br></div><div>-eric</div><br></body></html>