[cfe-commits] [PATCH] Fix default cpu for -march=armv5e

Evgeniy Stepanov eugeni.stepanov at gmail.com
Wed Apr 25 01:07:19 PDT 2012


Hi, James,

I could add arm1026ejs to ARMTargetInfo::getCPUDefineSuffix, but then
it fails anyway because arm1026ejs is not in ARM.td.

I've added a test.

On Tue, Apr 24, 2012 at 6:29 PM, James Molloy <james.molloy at arm.com> wrote:
> Hi Evgeniy,
>
> The patch itself appears fine but you're missing a testcase. Could you please add one? The driver test suite is a bit lacking so for any fixes it would be really nice to know if we regress.
>
> Also you mention ARMTargetInfo::getCPUDefineSuffix, but you didn't submit a patch to fix that?
>
> Cheers,
>
> James
>
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Evgeniy Stepanov
> Sent: 24 April 2012 14:59
> To: cfe-commits at cs.uiuc.edu
> Subject: [cfe-commits] [PATCH] Fix default cpu for -march=armv5e
>
> Hi,
>
> arm1026ejs is armv5tej, and, what's worse, the mapping of cpu name to
> arch suffix in ARMTargetInfo::getCPUDefineSuffix does not know that it
> exists.
>
> Please review.
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: armv5e.patch
Type: application/octet-stream
Size: 1079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120425/4f7afa82/attachment.obj>


More information about the cfe-commits mailing list