[cfe-commits] [PATCH] Fix default cpu for -march=armv5e

[James Molloy]

Hi Evgeniy,

The patch itself appears fine but you're missing a testcase. Could you please add one? The driver test suite is a bit lacking so for any fixes it would be really nice to know if we regress.

Also you mention ARMTargetInfo::getCPUDefineSuffix, but you didn't submit a patch to fix that?

Cheers,

James

-----Original Message-----
From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Evgeniy Stepanov
Sent: 24 April 2012 14:59
To: cfe-commits at cs.uiuc.edu
Subject: [cfe-commits] [PATCH] Fix default cpu for -march=armv5e

Hi,

arm1026ejs is armv5tej, and, what's worse, the mapping of cpu name to
arch suffix in ARMTargetInfo::getCPUDefineSuffix does not know that it
exists.

Please review.