[cfe-commits] r149014 - in /cfe/trunk: include/clang/Basic/TokenKinds.def include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp lib/Parse/Parser.cpp test/CodeGenCXX/pr11797.cpp test/CodeGenCXX/pragma-visibility.cpp

[Rafael Espíndola]

> I've run into a case (<rdar://problem/10871094>) where #pragma GCC
> visibility is used inside of a class definition.  Do you think this is
> something we should try to accept?

I guess it is OK if it is opened at the class level and closed at the
class level. For example, it is probably OK to accept

class foo {
static int a;
#pragma ... push ...
static int b;
#pragma ... pop
};

but reject if the push or pop is missing or if they are inside a
method for example.

> -Eli

Cheers,
Rafael