[cfe-commits] r149014 - in /cfe/trunk: include/clang/Basic/TokenKinds.def include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp lib/Parse/Parser.cpp test/CodeGenCXX/pr11797.cpp test/CodeGenCXX/pragma-visibility.cpp

Eli Friedman eli.friedman at gmail.com
Wed Feb 22 18:47:46 PST 2012


On Wed, Jan 25, 2012 at 6:02 PM, Rafael Espindola
<rafael.espindola at gmail.com> wrote:
> Author: rafael
> Date: Wed Jan 25 20:02:57 2012
> New Revision: 149014
>
> URL: http://llvm.org/viewvc/llvm-project?rev=149014&view=rev
> Log:
> Fix our handling of #pragma GCC visibility.
> Now the lexer just produces a token and the parser is the one responsible for
> activating it.
> This fixes problem like the one pr11797 where the lexer and the parser were not
> in sync. This also let us be more strict on where in the file we accept
> these pragmas.

I've run into a case (<rdar://problem/10871094>) where #pragma GCC
visibility is used inside of a class definition.  Do you think this is
something we should try to accept?

-Eli



More information about the cfe-commits mailing list