[cfe-commits] [patch][pr12001] Avoid increasing visibility in some cases

Nico Weber thakis at chromium.org
Wed Feb 22 10:15:58 PST 2012


Doh, I think I found an issue with this patch :-/ I'm building a
reduced test case now, I'll post it here in a few hours.

Nico

On Tue, Feb 21, 2012 at 5:57 PM, Eric Christopher <echristo at apple.com> wrote:
>
> On Feb 19, 2012, at 7:11 PM, Rafael Ávila de Espíndola <rafael.espindola at gmail.com> wrote:
>
>> Nico noticed that the patch included an infinite loop from when I
>> renamed merge2 to mergeWithMin.
>>
>> An updated patch is attached.
>
> I think this is ok. Some more comments on the visibility that should be happening in the various testcases and where you use mergeWithMin would be helpful next time I need to review something through there.
>
> -eric




More information about the cfe-commits mailing list