[cfe-commits] [patch][pr12001] Avoid increasing visibility in some cases

Eric Christopher echristo at apple.com
Tue Feb 21 17:57:40 PST 2012


On Feb 19, 2012, at 7:11 PM, Rafael Ávila de Espíndola <rafael.espindola at gmail.com> wrote:

> Nico noticed that the patch included an infinite loop from when I
> renamed merge2 to mergeWithMin.
> 
> An updated patch is attached.

I think this is ok. Some more comments on the visibility that should be happening in the various testcases and where you use mergeWithMin would be helpful next time I need to review something through there.

-eric



More information about the cfe-commits mailing list