[cfe-commits] [patch] Don't mark libc++ functions as always_inline in debug mode.

Jeffrey Yasskin jyasskin at gmail.com
Mon Feb 20 08:07:24 PST 2012


On Mon, Feb 20, 2012 at 6:58 AM, Howard Hinnant <hhinnant at apple.com> wrote:
> This is more than just an optimization issue.  Experience with libstdc++ has shown a persistent ABI stability problem over the years with functions getting silently uninlined in one release of libstdc++.dylib and inlined in the next.  The best way to hold the ABI stable is to put inlining under my control, not the compielr's.
>
> For those clients wishing to change these settings, <__config> was designed to defer to the client's wishes from the command line:
>
> -D_LIBCPP_INLINE_VISIBILITY
>
> will be used in preference to whatever <__config> says (or if it doesn't, that's the bug to fix).

Ah, ok. Then I think the right thing to do is to have cmake pass those
flags to debug builds. I'll put together a patch along those lines
instead.




More information about the cfe-commits mailing list