[cfe-commits] [PATCH] Delayed template instantiation for late-parsed attributes
Delesley Hutchins
delesley at google.com
Wed Dec 21 14:43:07 PST 2011
Thanks for the review! Any interest in looking at the first template
patch? :-)
> Please avoid calling the function on a null pointer, rather than checking
> 'this' here. Such a call would have undefined behaviour by
> [class.mfct.non-static]p2.
Done.
> new DeclArgumentPack(*OldPack) ?
Done.
> This appears to be an unrelated change?
Yes -- it's a minor bugfix to thread safety attribute parsing that
should have been in a separate patch. :-)
> The prevailing style is to put the } and else on the same line.
Done.
--
DeLesley Hutchins | Software Engineer | delesley at google.com | 505-206-0315
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-template-delayed-attribute2.patch
Type: application/octet-stream
Size: 2559 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111221/a41c5c54/attachment.obj>
More information about the cfe-commits
mailing list