[cfe-commits] r139368 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/SemaCXX/warn-thread-safety-analysis.cpp

Chandler Carruth chandlerc at google.com
Fri Sep 9 09:13:53 PDT 2011


On Fri, Sep 9, 2011 at 9:07 AM, Caitlin Sadowski <supertri at google.com>wrote:

> +    // FIXME: It would be nice if this case printed without single quotes
> around
> +    // the phrase 'any mutex'
>

I think you should use two diagnostics, or use a %select in the message. The
C++ code shouldn't be providing "any mutex", all the text should come from
the diagnostic message table.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110909/edb19fc2/attachment.html>


More information about the cfe-commits mailing list