[cfe-commits] r138526 - /cfe/trunk/lib/StaticAnalyzer/Core/CFRefCount.cpp
chandlerc at google.com
Thu Aug 25 23:33:17 PDT 2011
On Thu, Aug 25, 2011 at 11:55 AM, Jordy Rose <jediknil at belkadan.com> wrote:
> On Aug 25, 2011, at 1:52, Frits van Bommel wrote:
> > On 25 August 2011 01:41, Jordy Rose <jediknil at belkadan.com> wrote:
> >> + llvm_unreachable("Invalid/unknown GC mode.");
> >> + return false;
> > llvm_unreachable() expands to either __builtin_unreachable() or a call
> > to a noreturn function. Either way, there should be no need for the
> > explicit return.
> Yeah, but the entire purpose of this is to silence a GCC warning about
> "missing return in a non-void function". Does GCC handle noreturn calls
> properly now?
I don't think we care about any versions that don't model this correctly.
There are numerous places in the codebase where it would fire if this were
not handled correctly.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits