[cfe-commits] r138526 - /cfe/trunk/lib/StaticAnalyzer/Core/CFRefCount.cpp

[Jordy Rose]

On Aug 25, 2011, at 1:52, Frits van Bommel wrote:

> On 25 August 2011 01:41, Jordy Rose <jediknil at belkadan.com> wrote:
>> +    llvm_unreachable("Invalid/unknown GC mode.");
>> +    return false;
> 
> llvm_unreachable() expands to either __builtin_unreachable() or a call
> to a noreturn function. Either way, there should be no need for the
> explicit return.

Yeah, but the entire purpose of this is to silence a GCC warning about "missing return in a non-void function". Does GCC handle noreturn calls properly now? Anyway, I didn't want to take the chance. But thanks...if you think it's safe to remove the return than I can.