[cfe-commits] [PATCH]Add PNaCl TargetInfo to Clang

Eric Christopher echristo at apple.com
Wed Aug 24 12:51:19 PDT 2011

On Aug 24, 2011, at 12:36 PM, Ivan Krasin wrote:

> Hi Eric,
> Please, find the updated patch attached or
> http://codereview.chromium.org/7717004/
> 1. I've updated RUN: lines as suggested. Now, it does not create temp files

Yeah, we try to avoid grep if at all possible :)

> 2. I've fixed __builtin_va_list definition and added a test for that
> (unrelated catch)

Looks good. Thanks!


More information about the cfe-commits mailing list