[cfe-commits] [PATCH]Add PNaCl TargetInfo to Clang

[Ivan Krasin]

Hi Eric,

Please, find the updated patch attached or
http://codereview.chromium.org/7717004/

1. I've updated RUN: lines as suggested. Now, it does not create temp files
2. I've fixed __builtin_va_list definition and added a test for that
(unrelated catch)

krasin

On Tue, Aug 23, 2011 at 7:13 PM, Eric Christopher <echristo at apple.com> wrote:
>
> On Aug 23, 2011, at 6:09 PM, Ivan Krasin wrote:
>
>> Eric,
>>
>> I've added almost comprehensive test. It checks platform defines and
>> the sizes of the standard types, including pointer size.
>> Thank you for insisting on writing a real test: I've fixed a minor
>> issue (forgot to call getArchDefines from getPlatformDefines).
>>
>> Please, find the patch attached. You can save your time on checking
>> what has been changed from the last patch here:
>> http://codereview.chromium.org/7717004/
>
> Looking better. Can you have the test use FileCheck directly instead of calling llvm-dis?
>
> You could even have multiple run lines to check that the compiler used is correct and then just execute another run line to compile the file with a different set of options and then pass that through to FileCheck.
>
> Thanks!
>
> -eric
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pnacl_target_proper_run.patch
Type: text/x-patch
Size: 5364 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110824/cb95335b/attachment.bin>