[cfe-commits] [PATCH]Add PNaCl TargetInfo to Clang

Ivan Krasin krasin at chromium.org
Tue Aug 23 18:09:46 PDT 2011


I've added almost comprehensive test. It checks platform defines and
the sizes of the standard types, including pointer size.
Thank you for insisting on writing a real test: I've fixed a minor
issue (forgot to call getArchDefines from getPlatformDefines).

Please, find the patch attached. You can save your time on checking
what has been changed from the last patch here:

Ivan Krasin

On Tue, Aug 23, 2011 at 4:26 PM, Eric Christopher <echristo at apple.com> wrote:
> On Aug 23, 2011, at 4:09 PM, Ivan Krasin wrote:
>> On Tue, Aug 23, 2011 at 4:08 PM, Eric Christopher <echristo at apple.com> wrote:
>>> On Aug 23, 2011, at 4:07 PM, Ivan Krasin wrote:
>>>> Hi Eric,
>>>> I have added a trivial test for Clang driver with -ccc-host-triple
>>>> le32-unknown-nacl. Please take a look.
>>> That is trivial.
>>> You should also add a set that test that the values that you have set in the target info are correct for your target.
>> Ok, I will do that.
>> Thanks for the suggestion.
> The rest of the patch is just fine btw :)
> -eric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pnacl_target_good_test.patch
Type: text/x-patch
Size: 5163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110823/251fe87b/attachment.bin>

More information about the cfe-commits mailing list