[cfe-commits] [PATCH]Add PNaCl TargetInfo to Clang

Eric Christopher echristo at apple.com
Tue Aug 23 16:26:01 PDT 2011


On Aug 23, 2011, at 4:09 PM, Ivan Krasin wrote:

> On Tue, Aug 23, 2011 at 4:08 PM, Eric Christopher <echristo at apple.com> wrote:
>> 
>> On Aug 23, 2011, at 4:07 PM, Ivan Krasin wrote:
>> 
>>> Hi Eric,
>>> 
>>> I have added a trivial test for Clang driver with -ccc-host-triple
>>> le32-unknown-nacl. Please take a look.
>> 
>> That is trivial.
>> 
>> You should also add a set that test that the values that you have set in the target info are correct for your target.
> Ok, I will do that.
> 
> Thanks for the suggestion.

The rest of the patch is just fine btw :)

-eric



More information about the cfe-commits mailing list