[cfe-commits] PATCH: Better handle overloaded functions in typo correction

Chandler Carruth chandlerc at google.com
Mon Aug 1 17:38:11 PDT 2011

On Mon, Aug 1, 2011 at 4:25 PM, Kaelyn Uhrain <rikka at google.com> wrote:

> The use of a special non-NULL value for the CorrectionDecl* was needed when
> the TypoCorrection stored just one NamedDecl pointer to avoid an extra
> internal boolean flag and a bunch of handling for it, but is unneeded now
> that TypoCorrection stores a list of NamedDecl pointers (can now do empty
> list vs NULL first element). I've attached the updated patch for real this
> time--sorry for accidentally sending my previous email with a missing
> attachment.

This looks pretty good to me. Can you comment (maybe around isKeyword,
and/or any other relevant function) that we represent a keyword result with
a null pointer in the decls vector?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110801/fc11d4e8/attachment.html>

More information about the cfe-commits mailing list