[cfe-commits] r135749 - in /cfe/trunk: include/clang/Serialization/ASTWriter.h lib/Serialization/GeneratePCH.cpp

[Douglas Gregor]

On Jul 21, 2011, at 11:43 PM, David Blaikie wrote:

>>   PCHGenerator(const Preprocessor &PP, const std::string &OutputFile, bool Chaining,
>>                const char *isysroot, raw_ostream *Out);
> 
> Just curious - but why is isysroot a raw C style string, but
> OutputFile a std::string? (especially the member storing isysroot as a
> raw C string, rather than a std::string seems strange. The actual ctor
> arguments could both be StringRef, I assume - but the member type
> difference (that leads to you manually allocating/freeing the isysroot
> member) is what has me really wondering)

Because I was lazy, and this got in the way of the patch I *wanted* to commit at that point. Thanks for the prodding; I've fixed in r135769.

	- Doug