[cfe-commits] r135749 - in /cfe/trunk: include/clang/Serialization/ASTWriter.h lib/Serialization/GeneratePCH.cpp

[David Blaikie]

>   PCHGenerator(const Preprocessor &PP, const std::string &OutputFile, bool Chaining,
>                const char *isysroot, raw_ostream *Out);

Just curious - but why is isysroot a raw C style string, but
OutputFile a std::string? (especially the member storing isysroot as a
raw C string, rather than a std::string seems strange. The actual ctor
arguments could both be StringRef, I assume - but the member type
difference (that leads to you manually allocating/freeing the isysroot
member) is what has me really wondering)

- David