[cfe-commits] r135300 - /cfe/trunk/test/CMakeLists.txt

NAKAMURA Takumi geek4civic at gmail.com
Wed Jul 20 10:21:29 PDT 2011


Doug, thank you and excuse me to bother you.

2011/7/20 Douglas Gregor <dgregor at apple.com>:
> The problem is that the check.deps target doesn't exist if LLVM_INCLUDE_TESTS wasn't set, which caused CMake to error and exit.

I had missed the behavior of LLVM_INCLUDE_TESTS. I was sorry I had broken.

>     if ( LLVM_INCLUDE_TESTS )
> -      add_dependencies(clang-test.deps ClangUnitTests)
> +      add_dependencies(clang-test.deps check.deps ClangUnitTests)
>     endif ( LLVM_INCLUDE_TESTS )

It makes redundant dependencies. (Yeah, clang-test might not need bugpoint etc.)
I will rework later, to suppress whole "check-all" without LLVM_INCLUDE_TESTS.

Of course I will not forget to check with LLVM_INCLUDE_TESTS=OFF ;)

...Takumi




More information about the cfe-commits mailing list