[cfe-commits] r135300 - /cfe/trunk/test/CMakeLists.txt

[Douglas Gregor]

On Jul 20, 2011, at 4:17 AM, NAKAMURA Takumi wrote:

> Good evening, Doug!
> 
> 2011/7/16 Douglas Gregor <dgregor at apple.com>:
>> Don't refer to check.deps unless LLVM_INCLUDE_TESTS is enabled
> 
> I understand LLVM_INCLUDE_TESTS might control whether unittests would
> be executed with testing targets.
> In contrast, on autoconf build, "check-all" should test "llvm tests",
> "llvm unittests", "clang tests" and "clang unittests", I supposed.
> 
> You can take the target "clang-test" if you would not like to execute
> llvm tests. I intended LLVM_INCLUDE_TESTS should affect "clang-test"
> whether to execute clang unittests.
> 
> Or, please add descriptions to LLVM_INCLUDE_TESTS in
> llvm/cmake/modules/HandleLLVMOptions.cmake, to mention which tests
> might be executed.
> 
> Please hear, on the IRC, how you had troubled with "check-all", thank
> you arigato. ;)


The problem is that the check.deps target doesn't exist if LLVM_INCLUDE_TESTS wasn't set, which caused CMake to error and exit.

	- Doug