[cfe-commits] [PATCH] Implement -MG

Chris Lattner clattner at apple.com
Thu Jun 30 11:40:26 PDT 2011


On Jun 30, 2011, at 9:54 AM, Peter Collingbourne wrote:

> Hi,
> 
> This patch implements -MG (and fixes PR9613).  OK to commit?
> 
> One potential issue with this patch is that it introduces a
> preprocessor flag whose purpose is to "manually" disable a fatal
> diagnostic, since I couldn't see a way to do this within the existing
> diagnostic system (Diagnostic::setDiagnosticMapping contains an assert
> which explicitly forbids this).

Cool, thanks for working on this.  Instead of tackling it this way, how about switching err_cannot_open_file diagnostic to be a warning (which default maps to fatal) with no -W flag.  Then the preprocessor could just remap this to ignore when in -MG mode.

What do you think?

-Chris



More information about the cfe-commits mailing list