[cfe-commits] [PATCH] Refactoring of vtable and VTT builders

[Peter Collingbourne]

On Fri, Jun 17, 2011 at 02:25:20PM +0100, Peter Collingbourne wrote:
> On Tue, Jun 14, 2011 at 03:02:05AM +0100, Peter Collingbourne wrote:
> > On Mon, Jun 13, 2011 at 03:19:11PM -0700, Anders Carlsson wrote:
> > > 
> > > On Jun 13, 2011, at 12:41 PM, Peter Collingbourne wrote:
> > > 
> > > > Hi,
> > > > 
> > > > This patch refactors the vtable and VTT builders to provide a
> > > > backend-neutral interface to the builders in the AST library, which
> > > > CodeGen uses to build vtables and VTTs in LLVM.  No functionality
> > > > change intended.
> > > 
> > > While I'm not crazy about this idea, other people (Doug) are in favor of it, so I'm reluctantly fine with it :)
> > > 
> > > That being said, I don't think this patch should be committed in its current state. This should be done in incremental steps,
> > > there's no reason to move both the VTT builder and VTable builder in a single commit.
> > 
> > OK, then.  Following your and Eli's suggestions I will try to
> > break this patch up into the following steps:
> > 
> > 1) Move GlobalDecl to AST
> > 2) Make VTTBuilder independent of CodeGen (broken into sub-steps)
> > 3) Move VTTBuilder to AST
> > 4) Make VTableBuilder independent of CodeGen (broken into sub-steps)
> > 5) Move VTableBuilder to AST
> 
> I have attached the remaining patches covering 2-5.  Reviews
> appreciated.

Ping, and an update to patches 1, 4 and 13.

Thanks,
-- 
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-the-VTTBuilder-class-independent-of-LLVM-core.patch
Type: text/x-diff
Size: 16125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110630/cfc6f8a1/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Move-VTT-builder-to-AST.patch
Type: text/x-diff
Size: 43125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110630/cfc6f8a1/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-Move-VTable-builder-to-AST.patch
Type: text/x-diff
Size: 140861 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110630/cfc6f8a1/attachment-0002.patch>