[cfe-commits] Changes PPCallback to export the search path in InclusionDirective (issue4430065)

Chandler Carruth chandlerc at gmail.com
Tue Apr 26 14:45:08 PDT 2011


LGTM

(after you made the changes requested inside of rietveld)

Feel free to submit.

On Mon, Apr 25, 2011 at 6:22 PM, <klimek at google.com> wrote:

> Reviewers: chandlerc1,
>
> Description:
> To be able to replay compilations we need to accurately remodel how
> includes get resolved, especially when they are found relatively to
> another include file. We also try to get it working for framework
> includes, but that part of the code is untested, as I don't have a code
> base that uses it.
>
> Please review this at http://codereview.appspot.com/4430065/
>
> Affected files:
>   M include/clang/Lex/DirectoryLookup.h
>   M include/clang/Lex/HeaderMap.h
>   M include/clang/Lex/HeaderSearch.h
>   M include/clang/Lex/PPCallbacks.h
>   M include/clang/Lex/PreprocessingRecord.h
>   M include/clang/Lex/Preprocessor.h
>   M lib/Lex/HeaderMap.cpp
>   M lib/Lex/HeaderSearch.cpp
>   M lib/Lex/PPDirectives.cpp
>   M lib/Lex/PPMacroExpansion.cpp
>   M lib/Lex/Pragma.cpp
>   M lib/Lex/PreprocessingRecord.cpp
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110426/fade678e/attachment.html>


More information about the cfe-commits mailing list