LGTM<div><br></div><div>(after you made the changes requested inside of rietveld)</div><div><br></div><div>Feel free to submit.</div><div><br><div class="gmail_quote">On Mon, Apr 25, 2011 at 6:22 PM,  <span dir="ltr"><<a href="mailto:klimek@google.com">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Reviewers: chandlerc1,<br>
<br>
Description:<br>
To be able to replay compilations we need to accurately remodel how<br>
includes get resolved, especially when they are found relatively to<br>
another include file. We also try to get it working for framework<br>
includes, but that part of the code is untested, as I don't have a code<br>
base that uses it.<br>
<br>
Please review this at <a href="http://codereview.appspot.com/4430065/" target="_blank">http://codereview.appspot.com/4430065/</a><br>
<br>
Affected files:<br>
   M include/clang/Lex/DirectoryLookup.h<br>
   M include/clang/Lex/HeaderMap.h<br>
   M include/clang/Lex/HeaderSearch.h<br>
   M include/clang/Lex/PPCallbacks.h<br>
   M include/clang/Lex/PreprocessingRecord.h<br>
   M include/clang/Lex/Preprocessor.h<br>
   M lib/Lex/HeaderMap.cpp<br>
   M lib/Lex/HeaderSearch.cpp<br>
   M lib/Lex/PPDirectives.cpp<br>
   M lib/Lex/PPMacroExpansion.cpp<br>
   M lib/Lex/Pragma.cpp<br>
   M lib/Lex/PreprocessingRecord.cpp<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>