[cfe-commits] r129465 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/FixIt/no-macro-fixit.c

[jahanian]

On Apr 13, 2011, at 2:18 PM, Douglas Gregor wrote:

> 
> On Apr 13, 2011, at 2:02 PM, Eli Friedman wrote:
> 
>> On Wed, Apr 13, 2011 at 1:31 PM, Fariborz Jahanian <fjahanian at apple.com> wrote:
> 
> Actually, this is strange: I thought this code already existed. I wonder why the Fix-Its with macro-instantiation source locations aren't getting implicitly dropped appropriately?

Because, it turns out to eventually become a null SourceLocation. I think the right fix is to pass the macro-instantiation source locations  and see if it magically
drops the fixit. I will take a look.

- thanks,  fariborz

> 
>> 3. Why can't we come up with the "right" source location here?
> 
> 
> This is an interesting special case, where the source location we're looking at is in a macro instantiation but the actual fix could go into the file itself. We probably could detect this case, and make it work. Personally, I don't think it's worth the effort.
> 
> 	- Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110413/c413efdb/attachment.html>