<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 13, 2011, at 2:18 PM, Douglas Gregor wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On Apr 13, 2011, at 2:02 PM, Eli Friedman wrote:<br><br><blockquote type="cite">On Wed, Apr 13, 2011 at 1:31 PM, Fariborz Jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:<br></blockquote><font class="Apple-style-span" color="#540000"><br></font>Actually, this is strange: I thought this code already existed. I wonder why the Fix-Its with macro-instantiation source locations aren't getting implicitly dropped appropriately?<br></div></blockquote><div><br></div>Because, it turns out to eventually become a null SourceLocation. I think the right fix is to pass the macro-instantiation source locations and see if it magically</div><div>drops the fixit. I will take a look.</div><div><br></div><div>- thanks, fariborz</div><div><br><blockquote type="cite"><div><br><blockquote type="cite">3. Why can't we come up with the "right" source location here?<br></blockquote><br><br>This is an interesting special case, where the source location we're looking at is in a macro instantiation but the actual fix could go into the file itself. We probably could detect this case, and make it work. Personally, I don't think it's worth the effort.<br><br><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div></blockquote></div><br></body></html>