[cfe-commits] PATCH: Style and control flow cleanup to array bounds checking code

Ted Kremenek kremenek at apple.com
Thu Feb 17 08:58:06 PST 2011


LGTM.

On Feb 17, 2011, at 2:52 AM, Chandler Carruth wrote:

> And a follow-up that adds a bunch more tests and functionality to this checker. Specifically, it catches several C++ constructs and simple member variable uses. This incorporates the last of the functionality that we had implemented in our parallel work on the array bounds check warning.
> 
> Note that I still need to clean up a couple of tests in the suite which are actually triggering this warning. =] Not really interesting for the review though.
> 
> On Thu, Feb 17, 2011 at 12:25 AM, Chandler Carruth <chandlerc at google.com> wrote:
> Hey Ted,
> 
> I was working on merging in some of the extra checking logic our version had, and wanted to send a separate patch just for style cleanups. This should have no functionality changed, it just uses what I think are clearer and more consistent names in LLVM/Clang and reflows the code a bit to make the various branches a bit easier for me to follow. This look good to you?
> 
> <enhance-array-checking.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110217/9f22e418/attachment.html>


More information about the cfe-commits mailing list